Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 45: (2 comments) http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@3576 PS45, Line 3576: | IDENT:name : {: RESULT = new PlanHint(name); :} : | IDENT:name LPAREN ident_list:args RPAREN : {: RESULT = new PlanHint(name, args); :} : | IDENT:name LPAREN INTEGER_LITERAL:value RPAREN These are harmless uses of IDENT, but I think we should change them to ident_or_unreserved anyway. It's just a completeness thing. We may add more keywords to ident_or_unreserved down the road. http://gerrit.cloudera.org:8080/#/c/21930/45/fe/src/main/cup/sql-parser.cup@4621 PS45, Line 4621: | KW_KILL:r > These are necessary to also allow "kill" and "query" to be used as identifi "word" has limited usage. One is in struct field definitions: https://github.com/apache/impala/blob/master/fe/src/main/cup/sql-parser.cup#L4334 Another is the right side of a "set foo = X". The X could be a keyword. e.g. https://github.com/apache/impala/blob/master/fe/src/main/cup/sql-parser.cup#L3265 I think we need this for this test case in ParserTest: https://github.com/apache/impala/blob/master/fe/src/test/java/org/apache/impala/analysis/ParserTest.java#L3621-L3629 -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 45 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2025 22:53:10 +0000 Gerrit-HasComments: Yes
