Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 44: (4 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/21930/38//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21930/38//COMMIT_MSG@18 PS38, Line 18: For backward compatibility, 'KILL' and 'QUERY' : are added as "unreserved keywords", like 'DEFAULT'. This allows t > Introducing a new SQL should have no backward compatibility issues, and cre Thanks! Removed the new flag in the new Patch Set. http://gerrit.cloudera.org:8080/#/c/21930/30/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/30/be/src/service/client-request-state.cc@2532 PS30, Line 2532: } > Status can be the accumulation of multiple Status messages with MergeStatus Thanks! Changed. http://gerrit.cloudera.org:8080/#/c/21930/39/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21930/39/fe/src/main/cup/sql-parser.cup@362 PS39, Line 362: terminal FACTORIAL; // Placeholder terminal for postfix factorial operator : terminal COMMENTED_PLAN_HINT_START, COMMENTED_PLAN_HINT_END; : terminal String IDENT; > See other comment. Got it. Thanks! http://gerrit.cloudera.org:8080/#/c/21930/39/fe/src/main/cup/sql-parser.cup@4371 PS39, Line 4371: :} > New keywords should be added here. Thanks! Added. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 44 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:15:42 +0000 Gerrit-HasComments: Yes
