Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 44: (2 comments) > Patch Set 34: > > (2 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/21930/34//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21930/34//COMMIT_MSG@19 PS34, Line 19: dded as "unreserved keywords" > Best to create TReservedWordsVersion.IMPALA_4_5 and control this enablement Thanks! Removed the new flag in the new Patch Set. In the new Patch Set we don't need to use any flag. http://gerrit.cloudera.org:8080/#/c/21930/34/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21930/34/be/src/service/client-request-state.cc@2507 PS34, Line 2507: Status rpc_status = RpcMgr::DoRpcWithRetry(proxy, &ControlServiceProxy::KillQuery, : request, &response, query_ctx_, "KillQuery() RPC failed", num_retries, timeout_ms, : backoff_time_ms, "CRS_KILL_QUERY_RPC"); > Please leave a comment here and in commit message that KILL query is not ca Thanks! Added. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 44 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:22:06 +0000 Gerrit-HasComments: Yes
