Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 46: (1 comment) http://gerrit.cloudera.org:8080/#/c/21930/45/tests/util/cancel_util.py File tests/util/cancel_util.py: http://gerrit.cloudera.org:8080/#/c/21930/45/tests/util/cancel_util.py@127 PS45, Line 127: client > The client is passed as parameter here to invoke client.cancel(handle). Also, ImpylaHS2Connection specifically should not be used to run multiple queries asynchronously, which I suspect is what assert_kill_ok and assert_kill_error want to do with an existing client. https://github.com/apache/impala/blob/3118e41c26f730a06d42994e678cab694c787649/tests/common/impala_connection.py#L156-L160 >From experience, BeeswaxConnection somehow does not have that restriction and >execute_async() of single client works fine for running multiple queries >asyncrhonously. See also: https://issues.apache.org/jira/browse/HIVE-11402 https://issues.apache.org/jira/browse/HIVE-14247 -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 46 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 20 Jan 2025 18:51:22 +0000 Gerrit-HasComments: Yes
