Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 39: (2 comments) http://gerrit.cloudera.org:8080/#/c/21930/39/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/21930/39/fe/src/main/cup/sql-parser.cup@362 PS39, Line 362: // A word is an arbitrary token composed of digits and at least one letter. Reserved : // words cannot be used as identifiers but they are words and can be used in query : // options, column attributes, etc. See other comment. http://gerrit.cloudera.org:8080/#/c/21930/39/fe/src/main/cup/sql-parser.cup@4371 PS39, Line 4371: word ::= New keywords should be added here. (See other comment for the related comment in this file.) -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 39 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 21:18:39 +0000 Gerrit-HasComments: Yes
