Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21683 )
Change subject: IMPALA-13304: Include aggregate instance-level metrics within experimental profile(V2) ...................................................................... Patch Set 9: (1 comment) Your plan in https://gerrit.cloudera.org/c/21683/8..9#message-7d992975_f6b1b3bb sounds good to me. As you get deep into this, I have 1 more request: http://gerrit.cloudera.org:8080/#/c/21683/9/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/21683/9/be/src/util/runtime-profile.cc@3029 PS9, Line 3029: void AggregatedRuntimeProfile::EventSequenceToJsonHelper(Value* parent, : Document* d, vector<Value>& labels, vector<vector<int64_t>>& timestamps, : vector<vector<int32_t>>& label_idxs) const { Can you add test for this method in runtime-profile-test.cc with both good and bad (missing events) case? Please refer to this doc on how to run a backend (C++) test. https://cwiki.apache.org/confluence/display/IMPALA/How+to+load%2C+run%2C+and+create+new+Impala+tests -- To view, visit http://gerrit.cloudera.org:8080/21683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49e18a7a7e1288e3e674e15b6fc86aad60a08214 Gerrit-Change-Number: 21683 Gerrit-PatchSet: 9 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 20:40:44 +0000 Gerrit-HasComments: Yes
