Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22011 )

Change subject: IMPALA-13179: Make non-deterministic functions ineligible for 
tuple caching
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java
File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java:

http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@169
PS5, Line 169: string_col = current_user()
> Is it possible to add a mixed testcase, like "select * from functional.allt
Is the idea to have other expressions that are eligible in addition to the 
ineligible conjunct? I can add a test case like that.

(Separately, I'm adding a mixed-case test case.)



--
To view, visit http://gerrit.cloudera.org:8080/22011
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9601dba87b3c8f24cbe42eca0d8070db42b50488
Gerrit-Change-Number: 22011
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 14 Nov 2024 18:41:31 +0000
Gerrit-HasComments: Yes

Reply via email to