Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22011 )
Change subject: IMPALA-13179: Make non-deterministic functions ineligible for tuple caching ...................................................................... Patch Set 6: Code-Review+1 (2 comments) It looks good to me. If no further comments, I am ready to give a +2 http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@174 PS5, Line 174: > Renamed this parameter lowerCaseNames and updated the comment. Done http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@169 PS5, Line 169: > Yeah, the idea is to see how it works for mixed expressions with non determ Done -- To view, visit http://gerrit.cloudera.org:8080/22011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9601dba87b3c8f24cbe42eca0d8070db42b50488 Gerrit-Change-Number: 22011 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 19:17:21 +0000 Gerrit-HasComments: Yes
