Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22011 )
Change subject: IMPALA-13179: Make non-deterministic functions ineligible for tuple caching ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22011/3/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/22011/3/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@151 PS3, Line 151: } else if (fnName.getFnNamePath().size() == 2) { > nit: I like return in each of the branches rather than using an extra varia Good point, done -- To view, visit http://gerrit.cloudera.org:8080/22011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9601dba87b3c8f24cbe42eca0d8070db42b50488 Gerrit-Change-Number: 22011 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 00:58:45 +0000 Gerrit-HasComments: Yes
