Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22011 )
Change subject: IMPALA-13179: Make non-deterministic functions ineligible for tuple caching ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@174 PS5, Line 174: names It seems to we need to ensure that all strings in names are lowercase. Since line 169 uses equalsIgnoreCase() for comparison, it might be helpful to add a comment in case future contributors may add uppercase strings to the set http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/22011/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@169 PS5, Line 169: string_col = current_user() Is it possible to add a mixed testcase, like "select * from functional.alltypes where id < 5000 and string_col = current_user()" -- To view, visit http://gerrit.cloudera.org:8080/22011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9601dba87b3c8f24cbe42eca0d8070db42b50488 Gerrit-Change-Number: 22011 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 03:53:56 +0000 Gerrit-HasComments: Yes
