Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21971 )
Change subject: IMPALA-13403: Trivial changes in StorageDescriptor of ALTER_TABLE event is not enough to decide file metadata reload can be skipped ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21971/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21971/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1953 PS3, Line 1953: skipFileMetadata When we reach here, 'skipFileMetadata' is always true since it's either set to true at L1949 or we return false at L1951. Then the if-branch at L1944 of checking columns and owner doesn't affect the final result, and we can remove it. This means if the ALTER_TABLE event doesn't change SD and whitelistedTblProperties, we will skip file metadata reloading. Can we add a log about the checks and the decision? E.g. "Skip reloading file metadata of table xxx since SD and whitelistedTblProperties not changed". -- To view, visit http://gerrit.cloudera.org:8080/21971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia969dd32385ac5a1a9a65890a5ccc8cd257f4b97 Gerrit-Change-Number: 21971 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 11 Nov 2024 01:02:47 +0000 Gerrit-HasComments: Yes
