Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21971 )
Change subject: IMPALA-13403: Trivial changes in StorageDescriptor of ALTER_TABLE event is not enough to decide file metadata reload can be skipped ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21971/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21971/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1940 PS1, Line 1940: skipFileMetadata = true; Can't field schema / owner change at the same time as non trivial sd props? I think that similar issues in the future could be avoided by doing these checks independently and always return false if something non-trivial changed. http://gerrit.cloudera.org:8080/#/c/21971/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1948 PS1, Line 1948: if (isCustomTblPropsChanged(whitelistedTblProperties, beforeTable, : afterTable)) { : return false; The logic could be a bit simpler if isCustomTblPropsChanged() would return early before checking owner/SD -- To view, visit http://gerrit.cloudera.org:8080/21971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia969dd32385ac5a1a9a65890a5ccc8cd257f4b97 Gerrit-Change-Number: 21971 Gerrit-PatchSet: 1 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 08:28:57 +0000 Gerrit-HasComments: Yes
