Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21971 )

Change subject: IMPALA-13403: Refactor the checks of skip reloading file 
metadata for ALTER_TABLE events
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21971/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/21971/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1938
PS5, Line 1938:         if (isTrivialSdPropsChanged(beforeTable.getSd(), 
afterTable.getSd())) {
              :           skipFileMetadata = true;
              :         } else {
              :           return false;
              :         }
nit: we can simplify this to

        if (!isTrivialSdPropsChanged(beforeTable.getSd(), afterTable.getSd())) {
          return false;
        }

It seems variable 'skipFileMetadata' is useless.


http://gerrit.cloudera.org:8080/#/c/21971/5/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1944
PS5, Line 1944:       if (!isCustomTblPropsChanged(whitelistedTblProperties, 
beforeTable, afterTable)) {
              :         skipFileMetadata = true;
              :       } else {
              :         return false;
              :       }
              :       infoLog("Skipping reloading of file metadata for table 
{}.{} since SD and " +
              :           "whitelistedTblProperties has not changed.", dbName_, 
tblName_);
              :       return skipFileMetadata;
nit: we can simplify this to

      if (isCustomTblPropsChanged(whitelistedTblProperties, beforeTable, 
afterTable)) {
        return false;
      }
      infoLog("Skipping reloading of file metadata for table {}.{} since SD and 
" +
          "whitelistedTblProperties has not changed.", dbName_, tblName_);
      return true;



--
To view, visit http://gerrit.cloudera.org:8080/21971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia969dd32385ac5a1a9a65890a5ccc8cd257f4b97
Gerrit-Change-Number: 21971
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Mon, 18 Nov 2024 08:20:58 +0000
Gerrit-HasComments: Yes

Reply via email to