Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21971 )
Change subject: IMPALA-13403: Trivial changes in StorageDescriptor of ALTER_TABLE event is not enough to decide file metadata reload can be skipped ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21971/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21971/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1949 PS2, Line 1949: skipFileMetadata = true; : } else { : return false; > IMO the function could be simpler (no need for skipFileMetadata/sdOrOwnerCh This scenario would fail the existing test case whether we don't expect to reload file metadata when same value is set for custom table property. Can you see if my latest change looks better? -- To view, visit http://gerrit.cloudera.org:8080/21971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia969dd32385ac5a1a9a65890a5ccc8cd257f4b97 Gerrit-Change-Number: 21971 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 06 Nov 2024 00:56:31 +0000 Gerrit-HasComments: Yes
