Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 14: (3 comments) Thanks again for your questions http://gerrit.cloudera.org:8080/#/c/21616/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21616/13//COMMIT_MSG@18 PS13, Line 18: r names, > nit: Maybe add short section in this commit message on how username is reso Done http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc File be/src/rpc/authentication-test.cc: http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc@304 PS13, Line 304: : // Unit test for GetEffectiveShortUser(). > Please also add username that contain '/' and '@' but not in correct kerber I reworked the user name handling to do some validation of kerberos names. This required moving some code around, generally the organization is slightly better. I also added some tests cases as you suggest here http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc@323 PS13, Line 323: {"krbtgt/[email protected]", "krbtgt"}, : {"User1/admin/STAFF/[email protected]", "User1"} : }; : for (const auto& pair : kerberos_name_mappings) { > Do we have doc somewhere describing valid username format? The kerberos user name is potentially very complex but I used the regex from https://github.com/hopshadoop/hops/blob/8e2d0d67bf09798cf5bdcc573df8d0300958c911/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java#L71 to do validation. And I added more tests -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2024 21:07:21 +0000 Gerrit-HasComments: Yes
