Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 15: (4 comments) Thanks for the review http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/rpc/authentication-test.cc File be/src/rpc/authentication-test.cc: http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/rpc/authentication-test.cc@324 PS14, Line 324: "User1/admin/STAFF/[email protected]" > What is the expected short name for following case? Yes this is an edge case :-( Both my code GetEffectiveShortUser() and kudu::security::MapPrincipalToLocalName() agree this is a legal name which maps to the empty string. http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/scheduling/admission-controller.cc@2527 PS14, Line 2527: ould never happen beca > nit: "Should never fail because" Done http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/scheduling/admission-controller.cc@2527 PS14, Line 2527: DCHECK_OK(status); > Use DCHECK_OK(status); Thanks http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/util/auth-util.h File be/src/util/auth-util.h: http://gerrit.cloudera.org:8080/#/c/21616/14/be/src/util/auth-util.h@46 PS14, Line 46: to a short username > nit: "to a short username (i.e., the testuser in testuser/[email protected]). Done -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 15 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 02 Nov 2024 01:26:45 +0000 Gerrit-HasComments: Yes
