Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 12: (3 comments) Made an important change to deal with kerberos names http://gerrit.cloudera.org:8080/#/c/21616/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21616/10//COMMIT_MSG@17 PS10, Line 17: TPoolStats (the data that is shared between Admission Control instances) : is extended to include a map from user name to a count of queries : running. > And just to double check, the username here is simply 'user', not 'user/ins Thanks for this good question. I have made a change so that this is now true http://gerrit.cloudera.org:8080/#/c/21616/11/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java: http://gerrit.cloudera.org:8080/#/c/21616/11/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java@225 PS11, Line 225: the > nit: the Done http://gerrit.cloudera.org:8080/#/c/21616/10/fe/src/test/resources/fair-scheduler-test.xml File fe/src/test/resources/fair-scheduler-test.xml: http://gerrit.cloudera.org:8080/#/c/21616/10/fe/src/test/resources/fair-scheduler-test.xml@27 PS10, Line 27: <queue name="queueD"> > Ack. Lets document this later that there can be two different limit in two OK, thanks -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 12 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2024 17:00:30 +0000 Gerrit-HasComments: Yes
