Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21616 )
Change subject: IMPALA-12345: Add user quotas to Admission Control ...................................................................... Patch Set 13: (4 comments) I think this is good now. Just have few more comments. Please rebase the patch if possible. http://gerrit.cloudera.org:8080/#/c/21616/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21616/10//COMMIT_MSG@17 PS10, Line 17: TPoolStats (the data that is shared between Admission Control instances) : is extended to include a map from user name to a count of queries : running. > Thanks for this good question. Done http://gerrit.cloudera.org:8080/#/c/21616/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21616/13//COMMIT_MSG@18 PS13, Line 18: user name nit: Maybe add short section in this commit message on how username is resolved. http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc File be/src/rpc/authentication-test.cc: http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc@304 PS13, Line 304: const char* unchanged_usernames[] = { : "andrew", "andrew_sherman", "andrew-sherman", "Andrew"}; Please also add username that contain '/' and '@' but not in correct kerberos principal format. http://gerrit.cloudera.org:8080/#/c/21616/13/be/src/rpc/authentication-test.cc@323 PS13, Line 323: : assertEffectiveShortUser("connected1", "delegated1", "delegated1"); : assertEffectiveShortUser("connected1", "", "connected1"); : assertEffectiveShortUser("[email protected]", "", "impala"); Do we have doc somewhere describing valid username format? Can we add test over invalid username format and see what is the outcome? -- To view, visit http://gerrit.cloudera.org:8080/21616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c33f3f2427db57fb9b6c593a4b22d5029549b41 Gerrit-Change-Number: 21616 Gerrit-PatchSet: 13 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2024 17:46:34 +0000 Gerrit-HasComments: Yes
