Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 62: (4 comments) Eliminated potential race condition http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.h File be/src/workload_mgmt/workload-management.h: http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.h@41 PS62, Line 41: impala::Status ParseSchemaVersionFlag(kudu::Version& target_schema_version); > nit: As a matter of convention, Impala code passes values that will be modi Ah, I thought I had seen where we switched to passing byref instead of passing pointers. Will switch back to pointers. http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.cc File be/src/workload_mgmt/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.cc@181 PS62, Line 181: /// associated mutex. > Associated mutex no longer exists. Let's instead say it should not be modif Done http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.cc@181 PS62, Line 181: /// associated mutex. > I think we might need to make this atomic. StartupChecks happens on the wor Yes, I'm puzzling through that case. It's highly unlikely but could happen. http://gerrit.cloudera.org:8080/#/c/21142/62/be/src/workload_mgmt/workload-management.cc@205 PS62, Line 205: // specified, parses the flag value into the parsed_target_schema_version variable. > This comments not correct anymore. Done -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 62 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 18:00:54 +0000 Gerrit-HasComments: Yes
