Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 64: Code-Review+1 (2 comments) Looks good to me, thanks! http://gerrit.cloudera.org:8080/#/c/21142/63/be/src/workload_mgmt/workload-management.h File be/src/workload_mgmt/workload-management.h: http://gerrit.cloudera.org:8080/#/c/21142/63/be/src/workload_mgmt/workload-management.h@46 PS63, Line 46: la::Status Startup > Done. Done http://gerrit.cloudera.org:8080/#/c/21142/64/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21142/64/tests/common/impala_test_suite.py@1437 PS64, Line 1437: "come into existence in the allowed timeframe".format(actual_log_path) nit: mention max_attempts & sleep_time_s here. Say, "come into existence after {}x{} seconds".format(actual_log_path, max_attempts, sleep_time_s) -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 64 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 18:59:03 +0000 Gerrit-HasComments: Yes
