Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 60: (1 comment) http://gerrit.cloudera.org:8080/#/c/21142/60/be/src/catalog/workload-management-init.cc File be/src/catalog/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/60/be/src/catalog/workload-management-init.cc@517 PS60, Line 517: : // Set the default hostname. The user can override this with the hostname flag. : RETURN_IF_ERROR(GetHostname(&FLAGS_hostname)); > It is interesting that only webserver.cc check if FLAGS_hostname is empty o Hmm, good question. I need to do more digging into this question. Setting the --hostname flag does something because I can see in the info logs and the coordinator backends UI where the value of the hostname flag is used. I'm wondering if most situations where hostname is referenced actually need an IP address, and thus it does not matter if using the value of the --hostname flag or the system default hostname since they will both resolve to the same IP address, unless running on a server with multiple IPs. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 60 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2024 22:45:12 +0000 Gerrit-HasComments: Yes
