Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 60: (1 comment) http://gerrit.cloudera.org:8080/#/c/21142/60/be/src/catalog/workload-management-init.cc File be/src/catalog/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/60/be/src/catalog/workload-management-init.cc@517 PS60, Line 517: : // Set the default hostname. The user can override this with the hostname flag. : RETURN_IF_ERROR(GetHostname(&FLAGS_hostname)); It is interesting that only webserver.cc check if FLAGS_hostname is empty or not. $ git grep -n "FLAGS_hostname.*empty" be/src/util/webserver.cc:565: if (!FLAGS_hostname.empty()) { Does that mean code in be/src/common/init.cc silently ignore initial value of FLAGS_hostname and replace it anyway, just like this L519 is? >From running "git log -S "FLAGS_hostname.empty"", it looks like the check is >missing for the first time around this code: ImpalaD https://github.com/apache/impala/commit/dd2e58b7f2ccd9b09e486fb7e4149b934466d268#diff-afa7ddac6eae54c22c9ac2c17e402aa1058748f32475d47d1c8ee613f3c9d0c8L63 StatestoreD https://github.com/apache/impala/commit/41dc55b6664fa431912c0271fd8c6c08bef7f71b#diff-ad06e351913f1a60f64826264c89d75689789a00daffae9a5c2811df8cd42fc1L48 Perhaps the init code in be/src/common/init.cc should be fixed. Make them into a static function that is idempotent and use it both in init.cc and here. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 60 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2024 19:40:53 +0000 Gerrit-HasComments: Yes
