Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21550 )
Change subject: IMPALA-12800: Implement hashCode everywhere ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21550/2/fe/src/main/java/org/apache/impala/catalog/ArrayType.java File fe/src/main/java/org/apache/impala/catalog/ArrayType.java: http://gerrit.cloudera.org:8080/#/c/21550/2/fe/src/main/java/org/apache/impala/catalog/ArrayType.java@54 PS2, Line 54: return itemType_.hashCode(); Can we add a difference to the item's hash code? E.g. return 1 + itemType_.hashCode() Otherwise, array<array<int>>, array<int>, int both have the same hash code. http://gerrit.cloudera.org:8080/#/c/21550/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java: http://gerrit.cloudera.org:8080/#/c/21550/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java@26 PS2, Line 26: import java.beans.Transient; nit: unused? -- To view, visit http://gerrit.cloudera.org:8080/21550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I129bff6fd0968be135e23e0b24e273b2ea384eca Gerrit-Change-Number: 21550 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 25 Jun 2024 10:43:34 +0000 Gerrit-HasComments: Yes
