Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21550 )
Change subject: IMPALA-12800: Implement hashCode everywhere ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21550/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21550/1//COMMIT_MSG@10 PS1, Line 10: ScalarTypes could be equal, but have different hash codes. That caused > I was looking to understand why hashCode is different for equal objects. Re Stated another way, any class that overrides equals() must guarantee that a.equals(b) => (a.hasbCode() == b.hashCode()). It is desirable but not necessary to override hashCode() if a suitable hashCode() implementation has been inherited. -- To view, visit http://gerrit.cloudera.org:8080/21550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I129bff6fd0968be135e23e0b24e273b2ea384eca Gerrit-Change-Number: 21550 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 25 Jun 2024 17:36:35 +0000 Gerrit-HasComments: Yes
