Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21550 )
Change subject: IMPALA-12800: Implement hashCode everywhere ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21550/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21550/1//COMMIT_MSG@10 PS1, Line 10: ScalarTypes could be equal, but have different hash codes. That caused > Done I was looking to understand why hashCode is different for equal objects. Reading java docs, the reason is that the default implementation hashes instance memory addresses. Since ColumnDef does not inherit from anything, these is no suitable default implementation to fall back to. We should add comments in Expr classes or wherever is calling outside of Expr to ensure that non-derived classes have suitable hashCode implementations. -- To view, visit http://gerrit.cloudera.org:8080/21550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I129bff6fd0968be135e23e0b24e273b2ea384eca Gerrit-Change-Number: 21550 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 25 Jun 2024 17:28:02 +0000 Gerrit-HasComments: Yes
