Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21550
Change subject: IMPALA-12800: Implement hashCode everywhere ...................................................................... IMPALA-12800: Implement hashCode everywhere Fixes a regression in earlier IMPALA-12800 commits where two decimal ScalarTypes could be equal, but have different hash codes. That caused analysis to fail on statements that used the same cast-to-decimal expression twice, as one of them would fail to find a result in ExprSubstitutionMap. Overrides hashCode on every class that overrides equals to avoid other cases that might be untested, and avoid similar mistakes in the future. Adds a unit test covering the regression. Change-Id: I129bff6fd0968be135e23e0b24e273b2ea384eca --- M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java M fe/src/main/java/org/apache/impala/analysis/PlanHint.java M fe/src/main/java/org/apache/impala/catalog/ArrayType.java M fe/src/main/java/org/apache/impala/catalog/IcebergStructField.java M fe/src/main/java/org/apache/impala/catalog/MapType.java M fe/src/main/java/org/apache/impala/catalog/ScalarType.java M fe/src/main/java/org/apache/impala/catalog/StructType.java M fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java M fe/src/main/java/org/apache/impala/planner/DataPartition.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 10 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/21550/1 -- To view, visit http://gerrit.cloudera.org:8080/21550 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I129bff6fd0968be135e23e0b24e273b2ea384eca Gerrit-Change-Number: 21550 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]>
