On Mon, 7 Feb 2022 09:54:59 -0700 Alex Williamson <alex.william...@redhat.com> wrote:
> On Mon, 7 Feb 2022 17:08:01 +0100 > Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > > On 7/2/22 16:50, Alex Williamson wrote: > > > On Sat, 5 Feb 2022 10:49:35 +0000 > > > Peter Maydell <peter.mayd...@linaro.org> wrote: > > > > >> Hi; this has a format-string issue that means it doesn't build > > >> on 32-bit systems: > > >> > > >> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569 > > >> > > >> ../hw/vfio/common.c: In function 'vfio_listener_region_add': > > >> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of > > >> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka > > >> 'int'} [-Werror=format=] > > >> error_report("%s received unaligned region %s iova=0x%"PRIx64 > > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > >> ../hw/vfio/common.c:899:26: > > >> qemu_real_host_page_mask); > > >> ~~~~~~~~~~~~~~~~~~~~~~~~ > > >> > > >> For intptr_t you want PRIxPTR. > > > > > > Darn. Well, let me use this opportunity to ask, how are folks doing > > > 32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this > > > purpose, but I was eventually no longer able to maintain the build > > > dependencies. Looks like this failed on a mipsel cross build, but I > > > don't see such a cross compiler in Fedora. I do mingw32/64 cross > > > builds, but they leave a lot to be desired for code coverage. Thanks, > > > > You can use docker images: > > https://wiki.qemu.org/Testing/DockerBuild > > Hmm, not ideal... > > Clean git clone, HEAD 55ef0b702bc2 ("Merge remote-tracking branch > 'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging") > > $ make docker-test-quick@debian-mips64el-cross J=16 Accidentally selected the mips64el, but tests failing seems to be common. I can reproduce the build issue with either the mipsel or fedora-i386-cross, so I'll include some flavor of the test-build in my build script. Thanks, Alex