On 2/6/22 21:27, Gareth Webb wrote:
@@ -7382,6 +7383,8 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu) case 0: /* sldt */ if (!PE(s) || VM86(s)) goto illegal_op; + if ((PE(s) || LMA(s)) && s->cpuid_7_0_ecx_features & CPUID_7_0_ECX_UMIP && s->flags & HF_UMIP_MASK)
No need to check CPUID here (and below). If the bit is clear, HF_UMIP_MASK won't be set.
Otherwise looks good, thanks! Paolo