Re: [PATCH v1 02/20] s390x/tcg: Implement VECTOR BIT PERMUTE

[Richard Henderson]

On 9/30/20 9:55 AM, David Hildenbrand wrote:
> +        bit = !!(s390_vec_read_element8(v2, bit_nr / 8) &
> +                 (0x80 >> (bit_nr % 8)));

I think this would be clearer as

  bit = (s390_vec_read_element8(v2, bit_nr / 8)
         >> (7 - (bit_nr % 8))) & 1;

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~