frank.ch...@sifive.com writes:
> From: Kito Cheng <kito.ch...@sifive.com> > > Signed-off-by: Kito Cheng <kito.ch...@sifive.com> > Signed-off-by: Chih-Min Chao <chihmin.c...@sifive.com> > Signed-off-by: Frank Chang <frank.ch...@sifive.com> NACK I'm afraid. What's wrong with the exiting float_compare support? Even if you did want to bring in aliases for these functions within softfloat itself the correct way would be to use the decomposed float_compare support for a bunch of stubs and not restore the old style error prone bit masking code. > --- > fpu/softfloat.c | 240 ++++++++++++++++++++++++++++++++++++++++ > include/fpu/softfloat.h | 8 ++ > 2 files changed, 248 insertions(+) > > diff --git a/fpu/softfloat.c b/fpu/softfloat.c > index 028b857167..8bebea1142 100644 > --- a/fpu/softfloat.c > +++ b/fpu/softfloat.c > @@ -401,6 +401,34 @@ float64_gen2(float64 xa, float64 xb, float_status *s, > return soft(ua.s, ub.s, s); > } > > +/*---------------------------------------------------------------------------- > +| Returns the fraction bits of the half-precision floating-point value `a'. > +*----------------------------------------------------------------------------*/ > + > +static inline uint32_t extractFloat16Frac(float16 a) > +{ > + return float16_val(a) & 0x3ff; > +} For example you'll notice this function was deleted in e6b405fe00 -- Alex Bennée