On Fri, Jul 10, 2020 at 8:26 PM Alex Bennée <alex.ben...@linaro.org> wrote:

>
> Alex Bennée <alex.ben...@linaro.org> writes:
>
> > frank.ch...@sifive.com writes:
> >
> >> From: Kito Cheng <kito.ch...@sifive.com>
> >>
> >> Signed-off-by: Kito Cheng <kito.ch...@sifive.com>
> >> Signed-off-by: Chih-Min Chao <chihmin.c...@sifive.com>
> >> Signed-off-by: Frank Chang <frank.ch...@sifive.com>
> >
> > NACK I'm afraid. What's wrong with the exiting float_compare support?
> >
> > Even if you did want to bring in aliases for these functions within
> > softfloat itself the correct way would be to use the decomposed
> > float_compare support for a bunch of stubs and not restore the old style
> > error prone bit masking code.
>
> In fact see the example float32_eq inline function in the softfloat.h
> header.
>
> --
> Alex Bennée
>

Hi Alex,

Thanks for the suggestion of using wrong and old implementation and this
part will be refined in next separated softfloat PR.

Thanks
Chih-Min Chao

Reply via email to