On 6/25/20 10:09 AM, Peter Maydell wrote: >>> Comment says we're checking a memory attribute, but the code >>> is checking for TLB_MMIO, which isn't the same thing. >> >> Comment is not trying to allude to Normal vs Device, but "ram" vs "mmio" in >> the >> qemu sense. > > Oh, I see: maybe "if not backed by host RAM, then" ? I tend to > assume "normal memory" means "Normal memory" :-)
Sure, changed. Also noticed two more places where calling via mte_probe1 should not fault. r~
