On Tue, 23 Jun 2020 at 20:38, Richard Henderson <richard.hender...@linaro.org> wrote: > > Look up the physical address for the given virtual address, > convert that to a tag physical address, and finally return > the host address that backs it. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/mte_helper.c | 126 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 126 insertions(+) >
> + /* If not normal memory, there is no tag storage: access unchecked. */ > + if (unlikely(flags & TLB_MMIO)) { Comment says we're checking a memory attribute, but the code is checking for TLB_MMIO, which isn't the same thing. thanks -- PMM