Sounds good On Thu, Feb 06, 2020 at 03:21:42AM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 15, 2020 at 09:57:05PM -0500, Raphael Norwitz wrote: > > vhost_user_set_mem_table() and vhost_user_set_mem_table_postcopy() have > > gotten convoluted, and have some identical code. > > > > This change moves the logic populating the VhostUserMemory struct and > > fds array from vhost_user_set_mem_table() and > > vhost_user_set_mem_table_postcopy() to a new function, > > vhost_user_fill_set_mem_table_msg(). > > > > No functionality is impacted. > > > > Signed-off-by: Raphael Norwitz <raphael.norw...@nutanix.com> > > Signed-off-by: Peter Turschmid <peter.turs...@nutanix.com> > > > Looks ok, but just cosmetics: let's have the flag say what > it does, not who uses it. > > So s/postcopy/track_ramblocks/ ? >
