Yes - it's just a cleanup. On Thu, Feb 06, 2020 at 03:20:01AM -0500, Michael S. Tsirkin wrote: > > On Thu, Feb 06, 2020 at 03:17:04AM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 15, 2020 at 09:57:04PM -0500, Raphael Norwitz wrote: > > > The current vhost_user_set_mem_table_postcopy() implementation > > > populates each region of the VHOST_USER_SET_MEM_TABLE message without > > > first checking if there are more than VHOST_MEMORY_MAX_NREGIONS already > > > populated. This can cause memory corruption if too many regions are > > > added to the message during the postcopy step. > > > > > > This change moves an existing assert up such that attempting to > > > construct a VHOST_USER_SET_MEM_TABLE message with too many memory > > > regions will gracefully bring down qemu instead of corrupting memory. > > > > > > Signed-off-by: Raphael Norwitz <raphael.norw...@nutanix.com> > > > Signed-off-by: Peter Turschmid <peter.turs...@nutanix.com> > > > > > > Could you pls add Fixes: and stable tags? > > oh wait no, this is just a theoretical thing, right? > it doesn't actually trigger, it's just a cleanup. > > no fixes/stable needed then, sorry >
