On 10/24/2019 9:20 PM, Eduardo Habkost wrote:
On Thu, Oct 24, 2019 at 10:54:57AM +0100, Daniel P. Berrangé wrote:
On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote:
To convert strings with time suffixes to numbers, support time unit are
"ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms"
for millisecond or "s" for second.

Signed-off-by: Tao Xu <tao3...@intel.com>
---

No changes in v13.
---
  include/qemu/cutils.h |  1 +
  util/cutils.c         | 82 +++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 83 insertions(+)

This really ought to have an addition to the unit tests to validating
the parsing, both success and error scenarios, so that we're clear on
exactly what strings are accepted & rejected.

Unit tests are in patch 02/12.  It's a good idea to squash
patches 01 and 02 together.

Yes it is in 02/12. OK I will squash them.

Reply via email to