On Sun, Oct 20, 2019 at 07:11:14PM +0800, Tao Xu wrote: > To convert strings with time suffixes to numbers, support time unit are > "ps" for picosecond, "ns" for nanosecond, "us" for microsecond, "ms" > for millisecond or "s" for second. > > Signed-off-by: Tao Xu <tao3...@intel.com> > --- > > No changes in v13. > --- > include/qemu/cutils.h | 1 + > util/cutils.c | 82 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 83 insertions(+)
This really ought to have an addition to the unit tests to validating the parsing, both success and error scenarios, so that we're clear on exactly what strings are accepted & rejected. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
