On 10/21/2019 8:29 PM, Igor Mammedov wrote:
On Sun, 20 Oct 2019 19:11:18 +0800
Tao Xu <tao3...@intel.com> wrote:
In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT),
The initiator represents processor which access to memory. And in 5.2.27.3
Memory Proximity Domain Attributes Structure, the attached initiator is
defined as where the memory controller responsible for a memory proximity
domain. With attached initiator information, the topology of heterogeneous
memory can be described.
Extend CLI of "-numa node" option to indicate the initiator numa node-id.
In the linux kernel, the codes in drivers/acpi/hmat/hmat.c parse and report
the platform's HMAT tables.
Reviewed-by: Jingqi Liu <jingqi....@intel.com>
Suggested-by: Dan Williams <dan.j.willi...@intel.com>
Signed-off-by: Tao Xu <tao3...@intel.com>
---
[...]
+static void numa_validate_initiator(NumaState *numa_state)
+{
+ int i;
+ NodeInfo *numa_info = numa_state->nodes;
+
+ for (i = 0; i < numa_state->num_nodes; i++) {
+ if (numa_info[i].initiator == MAX_NODES) {
+ error_report("The initiator of NUMA node %d is missing, use "
+ "'-numa node,initiator' option to declare it.", i);
+ goto err;
+ }
+
+ if (!numa_info[numa_info[i].initiator].present) {
+ error_report("NUMA node %" PRIu16 " is missing, use "
+ "'-numa node' option to declare it first.",
+ numa_info[i].initiator);
+ goto err;
+ }
+
+ if (!numa_info[numa_info[i].initiator].has_cpu) {
+ error_report("The initiator of NUMA node %d is invalid.", i);
+ goto err;
+ }
+ }
+
+ return;
+
+err:
+ error_printf("\n");
error_report() does ^^^, drop it
OK, I will drop it.
with this fixed,
Reviewed-by: Igor Mammedov <imamm...@redhat.com>
[...]
