Patchew URL: https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190306031221.GA53@03612eec87fc Subject: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190306031221.GA53@03612eec87fc -> patchew/20190306031221.GA53@03612eec87fc Switched to a new branch 'test' e8052727ed qemu-binfmt-conf.sh: support QEMU_TARGETS a5fe269cca qemu-binfmt-conf.sh: update usage() e65c0db987 qemu-binfmt-conf.sh: refactor usage() 66b0955155 qemu-binfmt-conf.sh: add option --reset <ARCHS> 2200f3015d qemu-binfmt-conf.sh: generalize <CPU> to positional <CPUS> 686c9749cf qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX 0c9fb8d9aa qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options df7c3ef8c3 qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT e2f88c2bbf qemu-binfmt-conf.sh: make opts -p and -c boolean 08b6a8a8a1 qemu-binfmt-conf.sh: enforce safe style consistency === OUTPUT BEGIN === 1/10 Checking commit 08b6a8a8a145 (qemu-binfmt-conf.sh: enforce safe style consistency) WARNING: line over 80 characters #53: FILE: scripts/qemu-binfmt-conf.sh:299: + if [ "x$magic" = "x" ] || [ "x$mask" = "x" ] || [ "x$family" = "x" ] ; then total: 0 errors, 1 warnings, 47 lines checked Patch 1/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/10 Checking commit e2f88c2bbf66 (qemu-binfmt-conf.sh: make opts -p and -c boolean) ERROR: line over 90 characters #51: FILE: scripts/qemu-binfmt-conf.sh:327: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 43 lines checked Patch 2/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/10 Checking commit df7c3ef8c37d (qemu-binfmt-conf.sh: add QEMU_CREDENTIAL and QEMU_PERSISTENT) 4/10 Checking commit 0c9fb8d9aa9f (qemu-binfmt-conf.sh: remove 'qemu' prefix from cli options) ERROR: line over 90 characters #45: FILE: scripts/qemu-binfmt-conf.sh:331: +options=$(getopt -o ds:Q:S:e:hcp -l debian,systemd:,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 0 warnings, 40 lines checked Patch 4/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/10 Checking commit 686c9749cff9 (qemu-binfmt-conf.sh: honour QEMU_PATH and/or QEMU_SUFFIX) 6/10 Checking commit 2200f3015dd0 (qemu-binfmt-conf.sh: generalize <CPU> to positional <CPUS>) WARNING: line over 80 characters #80: FILE: scripts/qemu-binfmt-conf.sh:205: + Supported formats for CPUS are: single arch or comma/space separated list. WARNING: line over 80 characters #81: FILE: scripts/qemu-binfmt-conf.sh:206: + See QEMU target list below. If CPUS is 'ALL' or empty, configure all known ERROR: line over 90 characters #146: FILE: scripts/qemu-binfmt-conf.sh:367: +options=$(getopt -o :dsQ:S:e:hcp -l debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 2 warnings, 144 lines checked Patch 6/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/10 Checking commit 66b095515580 (qemu-binfmt-conf.sh: add option --reset <ARCHS>) WARNING: line over 80 characters #71: FILE: scripts/qemu-binfmt-conf.sh:375: + find /proc/sys/fs/binfmt_misc/ -type f -name $names -exec sh -c 'printf %s -1 > {}' \; ERROR: line over 90 characters #85: FILE: scripts/qemu-binfmt-conf.sh:390: +options=$(getopt -o r:dsQ:S:e:hcp -l reset:,debian,systemd,path:,suffix:,exportdir:,help,credential,persistent -- "$@") total: 1 errors, 1 warnings, 74 lines checked Patch 7/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/10 Checking commit e65c0db9871e (qemu-binfmt-conf.sh: refactor usage()) 9/10 Checking commit a5fe269cca58 (qemu-binfmt-conf.sh: update usage()) 10/10 Checking commit e8052727edf4 (qemu-binfmt-conf.sh: support QEMU_TARGETS) WARNING: line over 80 characters #44: FILE: scripts/qemu-binfmt-conf.sh:205: + Supported formats for TARGETS are: single arch or comma/space separated list. WARNING: line over 80 characters #45: FILE: scripts/qemu-binfmt-conf.sh:206: + See QEMU target list below. If TARGETS is 'ALL' or empty, configure all known total: 0 errors, 2 warnings, 62 lines checked Patch 10/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190306031221.GA53@03612eec87fc/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
