On Thu, Jun 15, 2017 at 19:25:07 -0400, Emilio G. Cota wrote: > Also, consider keeping the @is_jmp name instead of renaming it to > @jmp_type. (@jmp would be shorter but it would be confusing though, > e.g. cris has both dc->jmp and dc->is_jmp.)
It turns out that keeping the original names also makes the diff's a lot more bearable. I have a WIP branch with further modifications to your patches; the goal is to break down the patchset to make it more easily reviewable, which hopefully will also prevent us from introducing bugs. You can see the WIP tree at: https://github.com/cota/qemu/tree/trloop Note that I may rebase this branch any time. Cheers, Emilio
