Emilio G Cota writes:
> Some minor nits below.
> On Mon, Jun 12, 2017 at 17:54:09 +0300, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu>
>> ---
>> +/**
>> + * BreakpointHitType:
>> + * @BH_MISS: No hit
>> + * @BH_HIT_INSN: Hit, but continue translating instruction
>> + * @BH_HIT_TB: Hit, stop translating TB
>> + *
>> + * How to react to a breakpoint hit.
>> + */
>> +typedef enum BreakpointHitType {
>> + BH_MISS,
>> + BH_HIT_INSN,
>> + BH_HIT_TB,
>> +} BreakpointHitType;
> BH_MISS reads out loud to "Breakpoint Hit Miss"; that's quite
> counterintuitive.
> Similarly for the others (e.g. "breakpoint Hit Hit -- ??".
> Can we just do BP_{MISS,HIT,etc}? Thinking about it, perhaps BP_NONE is
> better than BP_MISS.
[...]
Will do.
Cheers,
Lluis
