On Fri, 9 May 2025 14:51:07 +0800 Zhao Liu <zhao1....@intel.com> wrote:
> On Thu, May 08, 2025 at 03:35:29PM +0200, Philippe Mathieu-Daudé wrote: > > Date: Thu, 8 May 2025 15:35:29 +0200 > > From: Philippe Mathieu-Daudé <phi...@linaro.org> > > Subject: [PATCH v4 06/27] hw/nvram/fw_cfg: Rename fw_cfg_init_mem_wide() -> > > fw_cfg_init_mem_dma() > > X-Mailer: git-send-email 2.47.1 > > > > "wide" in fw_cfg_init_mem_wide() means "DMA support". > > Rename for clarity. > > > > Suggested-by: Zhao Liu <zhao1....@intel.com> > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > > --- > > include/hw/nvram/fw_cfg.h | 6 +++--- > > hw/arm/virt.c | 2 +- > > hw/nvram/fw_cfg.c | 6 +++--- > > hw/riscv/virt.c | 4 ++-- > > 4 files changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h > > index d5161a79436..c4c49886754 100644 > > --- a/include/hw/nvram/fw_cfg.h > > +++ b/include/hw/nvram/fw_cfg.h > > @@ -309,9 +309,9 @@ FWCfgState *fw_cfg_init_io_dma(uint32_t iobase, > > uint32_t dma_iobase, > > AddressSpace *dma_as); > > FWCfgState *fw_cfg_init_mem_nodma(hwaddr ctl_addr, hwaddr data_addr, > > unsigned data_width); > > -FWCfgState *fw_cfg_init_mem_wide(hwaddr ctl_addr, > > - hwaddr data_addr, uint32_t data_width, > > - hwaddr dma_addr, AddressSpace *dma_as); > > +FWCfgState *fw_cfg_init_mem_dma(hwaddr ctl_addr, > > + hwaddr data_addr, uint32_t data_width, > > + hwaddr dma_addr, AddressSpace *dma_as); > > There's one more use in latest master: > > git grep fw_cfg_init_mem_wide > hw/loongarch/fw_cfg.c: fw_cfg = fw_cfg_init_mem_wide(VIRT_FWCFG_BASE + 8, > VIRT_FWCFG_BASE, 8, with that fixed: Reviewed-by: Igor Mammedov <imamm...@redhat.com>
