On Thu, 8 May 2025 15:35:27 +0200 Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
> fw_cfg_init_mem_wide() is prefered to initialize fw_cfg > with DMA support. Without DMA, use fw_cfg_init_mem_nodma(). > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Reviewed-by: Igor Mammedov <imamm...@redhat.com> > --- > hw/mips/loongson3_virt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c > index de6fbcc0cb4..654a2f0999f 100644 > --- a/hw/mips/loongson3_virt.c > +++ b/hw/mips/loongson3_virt.c > @@ -286,7 +286,7 @@ static void fw_conf_init(void) > FWCfgState *fw_cfg; > hwaddr cfg_addr = virt_memmap[VIRT_FW_CFG].base; > > - fw_cfg = fw_cfg_init_mem_wide(cfg_addr, cfg_addr + 8, 8, 0, NULL); just a question, given it's a rather modern machine is there a reason why it is not using DMA here? > + fw_cfg = fw_cfg_init_mem_nodma(cfg_addr, cfg_addr + 8, 8); > fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, > (uint16_t)current_machine->smp.cpus); > fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, > (uint16_t)current_machine->smp.max_cpus); > fw_cfg_add_i64(fw_cfg, FW_CFG_RAM_SIZE, loaderparams.ram_size);
