Thomas Huth <th...@redhat.com> writes:
> Hi!
>
> On 25/04/2025 17.13, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <phi...@linaro.org> writes:
>>> On 25/4/25 14:07, Thomas Huth wrote:
>>>> From: Thomas Huth <th...@redhat.com>
>>>> Python 3.8 went "end of life" in October 2024 and Fedora 42 dropped
>>>> this version already, so the "python" CI job is currently failing.
>>>> Thus it's time to drop support for this Python version in QEMU, too.
> ...
>>>> if test -z "${PYTHON}"; then
>>>> # A bare 'python' is traditionally python 2.x, but some distros
>>>> # have it as python 3.x, so check in both places.
>>>> - for binary in python3 python python3.12 python3.11 \
>>>> - python3.10 python3.9 python3.8; do
>>>> + for binary in python3 python python3.13 python3.12 python3.11 \
>>>
>>> The 3.13 test was missing in commit 45b14be9b63 ("python: enable testing
>>> for 3.13"). Preferably adding in a preliminary commit, otherwise mention
>>> in this patch description
>
> Yes, I'll add a sentence to the patch description!
>
>>> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
>
> Thanks!
>
>> Yes. The patch looks good to me otherwise. But John knows a lot more
>> about this stuff than I do; would be good to get his blessing.
>
> Seems like John is currently away from keyboard / busy with other stuff? I
> think we should go ahead and include this patch to get the CI green again, so
> I'll add it to my next pull request. If there is still anything that needs to
> be done on top, it can be done in another patch later.
Makes sense. I assume you'll amend the commit message to address
Philippe's review.
