On Wed, Apr 30, 2025 at 6:45 AM Markus Armbruster <arm...@redhat.com> wrote:
> Thomas Huth <th...@redhat.com> writes:
>
> > Hi!
> >
> > On 25/04/2025 17.13, Markus Armbruster wrote:
> >> Philippe Mathieu-Daudé <phi...@linaro.org> writes:
> >>> On 25/4/25 14:07, Thomas Huth wrote:
> >>>> From: Thomas Huth <th...@redhat.com>
> >>>> Python 3.8 went "end of life" in October 2024 and Fedora 42 dropped
> >>>> this version already, so the "python" CI job is currently failing.
> >>>> Thus it's time to drop support for this Python version in QEMU, too.
> > ...
> >>>> if test -z "${PYTHON}"; then
> >>>> # A bare 'python' is traditionally python 2.x, but some distros
> >>>> # have it as python 3.x, so check in both places.
> >>>> - for binary in python3 python python3.12 python3.11 \
> >>>> - python3.10 python3.9 python3.8; do
> >>>> + for binary in python3 python python3.13 python3.12 python3.11 \
> >>>
> >>> The 3.13 test was missing in commit 45b14be9b63 ("python: enable
> testing
> >>> for 3.13"). Preferably adding in a preliminary commit, otherwise
> mention
> >>> in this patch description
> >
> > Yes, I'll add a sentence to the patch description!
> >
> >>> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> >
> > Thanks!
> >
> >> Yes. The patch looks good to me otherwise. But John knows a lot more
> >> about this stuff than I do; would be good to get his blessing.
> >
> > Seems like John is currently away from keyboard / busy with other stuff?
> I think we should go ahead and include this patch to get the CI green
> again, so I'll add it to my next pull request. If there is still anything
> that needs to be done on top, it can be done in another patch later.
>
> Makes sense. I assume you'll amend the commit message to address
> Philippe's review.
Sorry, I was chasing the tail end of Sphinx fixes and fixing up the
standalone Python library which had quite a few problems with its CI, and I
figured I would then backport all of the various problems I encountered to
our CI here; I see you've already been tackling it while I was looking
away... sorry!
(Markus tried to warn me ...)
See also:
https://gitlab.com/qemu-project/python-qemu-qmp/-/merge_requests/34
https://gitlab.com/qemu-project/python-qemu-qmp/-/merge_requests/35
https://gitlab.com/gitlab-org/gitlab/-/issues/539290
If there are no objections to moving to 3.9 as the minimum, I certainly
don't mind. Go right ahead and I'll clean up afterwards as part of my
"delint qapi" series in which I'd like to fix quite a few other things that
are currently wonky. In fact, moving to 3.9 as a minimum might make all of
that much easier for me and allow deeper cleanings.
--js
