Philippe Mathieu-Daudé <phi...@linaro.org> writes: > Hi Thomas, > > On 25/4/25 14:07, Thomas Huth wrote: >> From: Thomas Huth <th...@redhat.com> >> Python 3.8 went "end of life" in October 2024 and Fedora 42 dropped >> this version already, so the "python" CI job is currently failing. >> Thus it's time to drop support for this Python version in QEMU, too. >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> This is an alternative suggestion to: >> https://lore.kernel.org/qemu-devel/20250422125626.72907-1-th...@redhat.com/ >> docs/about/build-platforms.rst | 2 +- >> configure | 14 +++++++------- >> python/Makefile | 8 ++++---- >> python/setup.cfg | 7 +++---- >> python/tests/minreqs.txt | 2 +- >> scripts/qapi/mypy.ini | 2 +- >> tests/docker/dockerfiles/python.docker | 1 - >> 7 files changed, 17 insertions(+), 19 deletions(-) > > >> if test -z "${PYTHON}"; then >> # A bare 'python' is traditionally python 2.x, but some distros >> # have it as python 3.x, so check in both places. >> - for binary in python3 python python3.12 python3.11 \ >> - python3.10 python3.9 python3.8; do >> + for binary in python3 python python3.13 python3.12 python3.11 \ > > The 3.13 test was missing in commit 45b14be9b63 ("python: enable testing > for 3.13"). Preferably adding in a preliminary commit, otherwise mention > in this patch description: > > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Yes. The patch looks good to me otherwise. But John knows a lot more about this stuff than I do; would be good to get his blessing. >> + python3.10 python3.9 ; do >> if has "$binary"; then >> python=$(command -v "$binary") >> if check_py_version "$python"; then
