Il 24/04/2012 10:49, Stefan Hajnoczi ha scritto: > "The error is specific to > block job speeds so we can add a speed argument to block-stream in the > future and clearly identify the invalid parameter." > > I added the new error to avoid having to change the InvalidParameter > 'name' field. It becomes ugly because we have: > block-job-set-speed <device> <value> > block-stream <device> [<speed>] [<base>] > > Notice that the parameter is called 'value' in block-job-set-speed and > 'speed' in block-stream. Therefore we can't just propagate a single > InvalidParameter name='value' error up from block-stream. > > This means that QMP commands will need to change the error to use the > correct name :(. It's doable, but ugly and a bit more complex.
Well, we still have time to change block-job-set-speed. Ugly, but doable. Paolo
