On Mon, Apr 23, 2012 at 4:42 PM, Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto:
>> + stream_start(bs, base_bs, base, block_stream_cb, bs, errp);
>> + if (error_is_set(errp)) {
>> + return;
>> }
>
> This needs to be
>
> Error *local_err = NULL;
> stream_start(bs, base_bs, base, block_stream_cb, bs, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> return;
> }
>
> Otherwise looks good.
Right, thanks for spotting this. Perhaps we should assert(errp) at
some point so we don't need to do this dance every time. Ignoring
errors is usually a bad idea...
For now I'll do the local_err thing.
Stefan
