On Mon, 23 Apr 2012 14:44:27 -0600 Eric Blake <ebl...@redhat.com> wrote:
> On 04/23/2012 01:38 PM, Anthony Liguori wrote: > >>> I like the approach of adding a new optional parameter; that is a > >>> workable solution for libvirt (that is, libvirt can assume that if the > >>> spelling 'block-stream' is available, then so is the optional 'speed' > >>> parameter, if this patch is included in time for qemu 1.1). > >> > >> The optional parameter is fine for me too, but we recently had a > >> discussion where it was decided that we should add new commands instead > >> of extending existing ones. > >> > >> Anthony, I believe we're already taking that position, right? > > > > Correct. It's impossible to tell whether a given version of QEMU > > supports extra parameters if we just add them to existing commands. > > Thankfully, block-stream is not an existing command, and we've already > created block-stream for qemu 1.1 as the new command that is explicitly > different from the block_stream of RHEL 6.2. Now is the time to get > this fix in, before we are stuck with bad semantics. Right, Paolo clarified this as well.
