Re: [PATCH intel_iommu 5/7] intel_iommu: extract device IOTLB invalidation logic

[Philippe Mathieu-Daudé]

On 22/4/24 17:52, CLEMENT MATHIEU--DRIF wrote:

This piece of code can be shared by both IOTLB invalidation and
PASID-based IOTLB invalidation

Signed-off-by: Clément Mathieu--Drif <clement.mathieu--d...@eviden.com>
---
  hw/i386/intel_iommu.c | 57 +++++++++++++++++++++++++------------------
  1 file changed, 33 insertions(+), 24 deletions(-)

  static bool vtd_process_device_iotlb_desc(IntelIOMMUState *s,
                                            VTDInvDesc *inv_desc)
  {
      VTDAddressSpace *vtd_dev_as;
-    IOMMUTLBEvent event;
      hwaddr addr;
-    uint64_t sz;
      uint16_t sid;
      bool size;

@@ -2912,6 +2941,7 @@ static bool vtd_process_device_iotlb_desc(IntelIOMMUState *s,

          return false;
      }

+

Spurious newline ;)

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

      /*